This repository has been archived by the owner on May 25, 2021. It is now read-only.
Adjust jest testMatch to work cross platform #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this change running tests (npm run test) returns 'No tests found' on windows. As per [jest issue #7914 #issuecomment-464352069](jestjs/jest#7914 (comment)) changing the [micromatch](https://github.com/micromatch/micromatch#extglobs) glob works on both OS's. There is a proposed solution but the jest code has not changed in that location.
james-martin-jd
approved these changes
Feb 26, 2020
|
LGTM. For future reference this seems to be the solution provided here: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change running tests (npm run test) returns 'No tests found' on windows.
As per jest issue #7914 #issuecomment-464352069 changing the micromatch glob works on both OS's.
There is a proposed solution but the jest code has not changed in that location.