Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed APIs don't work on VS Code 1.93.0 if the server-side folder URI contains query parameters #1427

Open
RyszardWithAZ opened this issue Sep 6, 2024 · 5 comments
Labels
bug Something isn't working upstream Depends on an upstream change (e.g. VS Code fix or enhancement, IRIS change)

Comments

@RyszardWithAZ
Copy link

Originally it stopped working for me in VSCode Insiders a few weeks ago, but I thought it was me, and I needed to find whether I messed up a setting.

But my stable VSCode just upgraded to 1.93.0 and Ctrl-P stopped working there as well. It's possible they renamed their Quick Open API or did something with the FileSearchProvider?

@isc-bsaviano
Copy link
Contributor

@RyszardWithAZ Are you sure you have a beta version installed? This is working for me on VS Code 1.93.0 with extension version 2.12.8-beta.1. The VS Code team has been doing work on the FileSearchProvider and TextSearchProvider in preparation for finalizing them, but that work hasn't broken the existing proposals.

@RyszardWithAZ
Copy link
Author

I am running
intersystems-community.vscode-objectscript version 2.12.8-beta.2 activating with proposed APIs available.
I also tried downgrading this to an older version and same deal.
That's weird that it's still working for you. I've done nothing else except let VSCode upgrade. Hm. And it's weird that my Insiders stopped working a while ago, and TODAY stable stopped working after I saw it upgraded.

@isc-bsaviano
Copy link
Contributor

Does the server-side text search work?

@isc-bsaviano
Copy link
Contributor

@RyszardWithAZ I believe this is a VS Code bug that only appears when the folder being searched has query parameters in the URI. I've opened microsoft/vscode#227836 to report it.

@RyszardWithAZ
Copy link
Author

Hmm, the server-side text search also doesn't work. Although now my entire shared dev env just went down. It's a Friday at 5:15. Yay. As soon as it comes back up (probably Monday), I can test that by rewriting my URI to not include any query parameters.

@isc-bsaviano isc-bsaviano added bug Something isn't working upstream Depends on an upstream change (e.g. VS Code fix or enhancement, IRIS change) labels Sep 9, 2024
@isc-bsaviano isc-bsaviano changed the title Ctrl-P for server-side quick open stopped working Proposed APIs don't work on VS Code 1.93.0 if the server-side folder URI contains query parameters Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Depends on an upstream change (e.g. VS Code fix or enhancement, IRIS change)
Projects
None yet
Development

No branches or pull requests

2 participants