Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: message catalogs not being compiled due to "fuzzy" #346

Closed
lnielsen opened this issue Oct 15, 2020 · 2 comments · Fixed by #357
Closed

i18n: message catalogs not being compiled due to "fuzzy" #346

lnielsen opened this issue Oct 15, 2020 · 2 comments · Fixed by #357

Comments

@lnielsen
Copy link
Member

Package version (if known): 1.3.0

Describe the bug

The distributed package on PyPI doesn't compile the message catalog of most languages (i.e we're lacking the .mo file). This is due to fuzzy being included in the messages.po.

Example of a good messages.po which does not include "fuzzy" and where the .mo file is correctly compiled.

Screenshot

Screenshot from files included in the PyPI distribution:
Screenshot 2020-10-15 at 11 46 31

@libremente
Copy link

libremente commented Oct 20, 2020

@lnielsen are those strings correctly reviewed?
#, fuzzy is the mark that gettext uses to determine that a translation content has to be reviewed. While this mark is there, the translation won't show up in run-time.
For example, in the Italian case I can see that 0% of the translations are reviewed and this explains the #fuzzy parameter being set
Schermata da 2020-10-20 18-43-56

Ref: https://docs.transifex.com/formats/gettext#fuzzy-matches

@lnielsen lnielsen added this to Backlog in Invenio v3.4 via automation Nov 29, 2020
@lnielsen lnielsen moved this from Backlog to To do in Invenio v3.4 Nov 29, 2020
@lnielsen
Copy link
Member Author

Note for the coming sprint:

@lnielsen lnielsen moved this from To do to Pending review in Invenio v3.4 Nov 29, 2020
@lnielsen lnielsen moved this from Pending review to Backlog in Invenio v3.4 Nov 30, 2020
@lnielsen lnielsen moved this from Backlog to To do in Invenio v3.4 Nov 30, 2020
@Glignos Glignos assigned Glignos and unassigned Glignos Dec 2, 2020
@ppanero ppanero moved this from To do to In progress in Invenio v3.4 Dec 4, 2020
@ppanero ppanero self-assigned this Dec 4, 2020
@ppanero ppanero moved this from In progress to Pending review in Invenio v3.4 Dec 4, 2020
Invenio v3.4 automation moved this from Pending review to Done Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Invenio v3.4
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants