Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Generation of src/components.d.ts typing broken in latest build #5859

Closed
3 tasks done
joewoodhouse opened this issue Jun 27, 2024 · 1 comment · Fixed by #5862
Closed
3 tasks done

bug: Generation of src/components.d.ts typing broken in latest build #5859

joewoodhouse opened this issue Jun 27, 2024 · 1 comment · Fixed by #5862
Assignees
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@joewoodhouse
Copy link
Contributor

Prerequisites

Stencil Version

4.19.0

Current Behavior

The generated src/components.d.ts file is corrupt, with missing identifiers in the import and export statements. For example:

import { HTMLStencilElement, JSXBase } from "@stencil/core/internal";
import {  as BBox } from "geojson";
export {  as BBox } from "geojson";
export namespace Components {
    interface AppHome {
    }
    interface AppProfile {
        "bbox": BBox;
    }
    interface AppRoot {
    }
}
...

Expected Behavior

The src/components.d.ts file should be built correctly.

If you switch back to @stencil/core@4.18.0 then the issue is no longer present.

System Info

❯ npx stencil info

      System: node 18.18.2
    Platform: darwin (23.5.0)
   CPU Model: Apple M1 Pro (8 cpus)
    Compiler: /Users/joewoodhouse/src/stencil-import-type-issue/node_modules/@stencil/core/compiler/stencil.js
       Build: 1719433468
     Stencil: 4.19.0 🏄
  TypeScript: 5.4.5
      Rollup: 2.56.3
      Parse5: 7.1.2
      jQuery: 4.0.0-pre
      Terser: 5.31.1

Steps to Reproduce

git clone https://github.com/joewoodhouse/stencil-import-types-issue
cd stencil-import-types-issue
npm install
npm run build
cat src/components.d.ts

Code Reproduction URL

https://github.com/joewoodhouse/stencil-import-types-issue

Additional Information

Almost certainly related to this change
7ffb25d#diff-1079cab98429d9a563cc8bb366896edc0ccf6b1c3e113771acf0ddaa3f52484b

@ionitron-bot ionitron-bot bot added the triage label Jun 27, 2024
@tanner-reits tanner-reits self-assigned this Jun 27, 2024
@tanner-reits
Copy link
Member

@joewoodhouse I've confirmed the issue here. We'll get a fix up for this ASAP!

@tanner-reits tanner-reits added Bug: Validated This PR or Issue is verified to be a bug within Stencil and removed triage labels Jun 27, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants