Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce changelog updates in CI #267

Closed
guseggert opened this issue Apr 5, 2023 · 1 comment · Fixed by #398
Closed

Enforce changelog updates in CI #267

guseggert opened this issue Apr 5, 2023 · 1 comment · Fixed by #398
Assignees
@galargh
Labels
dif/easy Someone with a little familiarity can pick up P1 High: Likely tackled by core team if no one steps up status/blocked Unable to be worked further until needs are met topic/build-and-release-fitness Items related to our CI process, dependency management, etc.

Comments

@guseggert
Copy link
Contributor

It'd be nice for CI to enforce changelog updates for each PR, or require explicit opt-out, so that when we start a release train, the release engineer doesn't need to cat-herd everyone to write changelog updates.

I've opened an issue here requesting this feature: ipdxco/changelog-driven-release#5
@guseggert guseggert added need/triage Needs initial labeling and prioritization P1 High: Likely tackled by core team if no one steps up dif/easy Someone with a little familiarity can pick up status/ready Ready to be worked status/blocked Unable to be worked further until needs are met and removed need/triage Needs initial labeling and prioritization status/ready Ready to be worked labels Apr 5, 2023
This was referenced Apr 5, 2023
Open
Open
@guseggert guseggert self-assigned this Apr 5, 2023
@BigLep BigLep added the topic/build-and-release-fitness Items related to our CI process, dependency management, etc. label Apr 6, 2023
@galargh
Copy link
Contributor

galargh commented May 15, 2023

We met w/ Gus to chat about this some more. Here are the things we plan to do for this:

  1. Introduce PR Template that nudges people toward filling out the changelog.
  2. Add a GHA which checks whether the changelog has been updated. The contributor will have ability to bypass that check. Ideas for bypassing the check: description, title, label, comment.

@galargh galargh assigned galargh and unassigned guseggert May 18, 2023
@galargh galargh mentioned this issue Jun 27, 2023
Merged
@BigLep BigLep mentioned this issue Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galargh galargh

Labels
dif/easy Someone with a little familiarity can pick up P1 High: Likely tackled by core team if no one steps up status/blocked Unable to be worked further until needs are met topic/build-and-release-fitness Items related to our CI process, dependency management, etc.
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add changelog update checker workflow ipfs/boxo
3 participants
@BigLep @guseggert @galargh