Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion support for Base32 CIDv1 #527

Closed
1 of 3 tasks
lidel opened this issue Jul 14, 2018 · 1 comment
Closed
1 of 3 tasks

Companion support for Base32 CIDv1 #527

lidel opened this issue Jul 14, 2018 · 1 comment
Labels
area/cidv1b32 Moving to CIDv1/Base32 by default kind/enhancement A net-new feature or improvement to an existing feature kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up status/in-progress In progress

Comments

@lidel
Copy link
Member

lidel commented Jul 14, 2018

This issue tracks changes required by our move to CIDv1 in Base32 (B32) as the new default.
Meta-issue is at: https://github.com/ipfs/ipfs/issues/337:

Lowercase identifiers are required in order to work with legacy URI, web browser security (sub)origins and the experimental Protocol Handler API. So we are moving to finish support for CIDv1 across the ecosystem, and use it as default (while still supporting CIDv0/Multihash).

Draft of TODOs

Descoped:

  • Detect CIDv0 (Base58) and provide option to convert it to cidv1b32
    • go-ipfs fixed lookup, no longer needed

the base32 strike force

@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up area/cidv1b32 Moving to CIDv1/Base32 by default labels Jul 14, 2018
@lidel lidel added status/ready Ready to be worked status/in-progress In progress and removed status/ready Ready to be worked labels Sep 22, 2018
@lidel
Copy link
Member Author

lidel commented Apr 28, 2020

This is no longer needed with go-ipfs 0.5:

@lidel lidel closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cidv1b32 Moving to CIDv1/Base32 by default kind/enhancement A net-new feature or improvement to an existing feature kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up status/in-progress In progress
Projects
None yet
Development

No branches or pull requests

1 participant