Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pin files #518

Closed
hacdias opened this issue Dec 4, 2017 · 16 comments
Closed

feat: pin files #518

hacdias opened this issue Dec 4, 2017 · 16 comments
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up

Comments

@hacdias
Copy link
Member

hacdias commented Dec 4, 2017

Some people (such as @flyingzumwalt and @mishmosh), would like to pin files. A great feature for later 😄

@hacdias hacdias mentioned this issue Dec 4, 2017
20 tasks
@daviddias
Copy link
Member

I would love it too! :D The use case I was thinking was for PeerPad peer-base/peer-pad#90

@hacdias hacdias changed the title Feature: Pin Files feat: pin files Dec 4, 2017
@daviddias daviddias added P1 High: Likely tackled by core team if no one steps up exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue labels Dec 11, 2017
@daviddias
Copy link
Member

@hacdias can you prioritize this feature?

@hacdias
Copy link
Member Author

hacdias commented Dec 11, 2017

Pin files like the way pinbot pins files? Or just have a different panel where we can pin the files to have their links handy?

@flyingzumwalt
Copy link
Contributor

Oh wow -- are you thinking of having station run pinning services, so I could just run station on a machine if I want to have a pinning service, and then have tools like peerpad use that as my preferred pinning service? That would be immediately useful. @hacdias read the related discussions in peer-base/peer-pad#90 if you haven't yet. That should help you get a sense of the functionality we want.

Though, now that I think of it, we should be careful to make sure all the related functionality (pinning service, configuration, etc) is packaged as something that you can run without station -- station should just be the installer and the UI for people who don't want to use the command line.

But still. I'm so excited to see this feature happen!

@hacdias I would be delighted to spend some time with you around designing this feature in order to get the user experience right. Timing is a bit tight though -- I'll be on vacation 14-21 December.

@daviddias
Copy link
Member

are you thinking of having station run pinning services, so I could just run station on a machine if I want to have a pinning service, and then have tools like peerpad use that as my preferred pinning service? That would be immediately useful

Exactly that! I knew you would like this feature, @flyingzumwalt :)

Pin files like the way pinbot pins files? Or just have a different panel where we can pin the files to have their links handy?

@hacdias that would be the ideal first version, a pane where users could pin hashes and add labels to them.

@hacdias
Copy link
Member Author

hacdias commented Dec 12, 2017

Okay, so we'll start by doing a pane where users can pin hashes and add labels to them. Will try to start this tomorrow (or Thursday maximum) and will open a PR. After the first 'version' is completed, we can move to a pinning service.

@flyingzumwalt all help is welcome 😄

@hacdias
Copy link
Member Author

hacdias commented Dec 30, 2017

Done people! Check it out!

@daviddias
Copy link
Member

@hacdias gifs or it didn't happen :)

@hacdias
Copy link
Member Author

hacdias commented Dec 30, 2017

@diasdavid

Pin a new hash

https://gyazo.com/cc95c17262a58052d43230cb756f5c09

Search

https://gyazo.com/7e1d694d77174bd6c3493812c11318ab

Animation while pinning

https://gyazo.com/72e7b03963fa2eec270b2516f4f84437

@daviddias
Copy link
Member

@hacdias wanna add as gifs all the features that Station has to the README and close this issue?

@ghost
Copy link

ghost commented Dec 30, 2017

Great! Suggestion: let's make these fully-qualified paths, a la /ipfs/QmFoo

@hacdias
Copy link
Member Author

hacdias commented Dec 30, 2017

Will do that @lgierth @diasdavid. I'll close this afterwards.

@whyrusleeping
Copy link
Member

Well now we need to add pin annotations support to the api, this looks really nice :)

@hacdias
Copy link
Member Author

hacdias commented Dec 30, 2017

@diasdavid @lgierth @whyrusleeping Look at this beautiful brand new README full of gifs: https://github.com/ipfs-shipyard/ipfs-station/blob/master/README.md

@hacdias hacdias closed this as completed Dec 30, 2017
@jbenet
Copy link
Member

jbenet commented Dec 30, 2017

Looking great! :)

@daviddias
Copy link
Member

@hacdias love it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

No branches or pull requests

5 participants