Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX when API port is already in use #739

Closed
lidel opened this issue Dec 9, 2018 · 1 comment
Closed

Improve UX when API port is already in use #739

lidel opened this issue Dec 9, 2018 · 1 comment

Comments

@lidel
Copy link
Member

lidel commented Dec 9, 2018

Current State

If I already have something running on port :5001 ipfs-desktop fails to start and generic error is displayed (3b7c781):

2018-12-09--19-53-56

Actual error can be found in logs:

Error: Command failed: /home/lidel/project/ipfs-desktop/node_modules/go-ipfs-dep/go-ipfs/ipfs daemon --migrate=true --routing=dhtclient
Error: serveHTTPApi: manet.Listen(/ip4/127.0.0.1/tcp/5001) failed: listen tcp4 127.0.0.1:5001: bind: address already in use

Initializing daemon...
go-ipfs version: 0.4.18-
Repo version: 7
System version: amd64/linux
Golang version: go1.11.1
Swarm listening on /ip6/::1/tcp/4001
Swarm listening on /p2p-circuit
Swarm announcing /ip6/::1/tcp/4001
Received interrupt signal, shutting down...
(Hit ctrl-c again to force-shutdown the daemon.)

    at makeError (/home/lidel/project/ipfs-desktop/node_modules/execa/index.js:174:9)
    at Promise.all.then.arr (/home/lidel/project/ipfs-desktop/node_modules/execa/index.js:278:16)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Proposed Improvements

IPFS Desktop should detect Error: serveHTTPApi: [...] bind: address already in use and

  • at minimum: display failed: listen tcp4 127.0.0.1:5001: bind: address already in use
  • nice to have: display UI for changing API port and retrying
  • extra: find a free port and display it in the UI so user does not guess what is safe to use
@lidel lidel added the UX label Dec 9, 2018
@lidel
Copy link
Member Author

lidel commented Apr 30, 2019

Continued in #912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant