Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinning services: amend CLI tutor mode helptext #1686

Closed
jessicaschilling opened this issue Nov 5, 2020 · 0 comments · Fixed by #1700
Closed

Pinning services: amend CLI tutor mode helptext #1686

jessicaschilling opened this issue Nov 5, 2020 · 0 comments · Fixed by #1700
Assignees
@jessicaschilling
Labels
area/pinning Integrating pinning into GUI apps effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work

Comments

@jessicaschilling
Copy link
Contributor

Once remote pinning service support is added, we'll need to add explanatory content to the CLI tutor modal to this effect: This command will only pin this item's CID to your local node. If you want to persist it with a remote pinning service, consult that service's CLI documentation to learn how.

Right now we have i18n key cliModal.extraNotes for that explanatory context, but it's effectively hard-coded for one use (the config in Settings). The best way to remedy might be to move cliModal.extraNotes out of app.json and into settings.json and files.json.
@jessicaschilling jessicaschilling self-assigned this Nov 5, 2020
@jessicaschilling jessicaschilling added area/pinning Integrating pinning into GUI apps exp/novice Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work labels Nov 5, 2020
This was referenced Nov 5, 2020
Merged
Closed
@jessicaschilling jessicaschilling mentioned this issue Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessicaschilling jessicaschilling

Labels
area/pinning Integrating pinning into GUI apps effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: separate CLI Tutor Mode helptext ipfs/ipfs-webui
1 participant
@jessicaschilling