Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Merge js-ipfs-{core pieces} into js-ipfs repo #2282

Closed
daviddias opened this issue Jul 20, 2019 · 3 comments
Closed

Merge js-ipfs-{core pieces} into js-ipfs repo #2282

daviddias opened this issue Jul 20, 2019 · 3 comments
Labels
need/analysis Needs further analysis before proceeding

Comments

@daviddias
Copy link
Member

Following #2222, the proposal is to:

Merge into js-ipfs, the following modules:

  • js-ipfs-mfs
  • js-ipfs-repo
  • js-ipfs-block-service
  • js-ipfs-unixfs-exporter
  • js-ipfs-unixfs-importer
@hugomrdias
Copy link
Member

@achingbrain do we have another issue to track this ?

@achingbrain
Copy link
Member

I'm not sure that we want to merge any more modules into the main repo at this time.

  • ipfs-mfs is in already
  • I don't think ipfs-repo is really high-churn enough, though we might fold that and the migration tool into one
  • The block service should just go away as it's only purpose is to delegate to either repo.blockstore or bitswap, which delegates to repo.blockstore so let's just configure components with one or the other during init/start (post or as part of refactor: remove proxy api object and detect initialisation state #2762)
  • The importer/exporter are similarly low churn, kind of happy with them where they are right now

We can, of course revisit these should the above things change.

@hugomrdias
Copy link
Member

cool lets close this then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
need/analysis Needs further analysis before proceeding
Projects
None yet
Development

No branches or pull requests

3 participants