Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multistream Version Handling #3044

Closed
whyrusleeping opened this issue Aug 5, 2016 · 1 comment · Fixed by #3132
Closed

Multistream Version Handling #3044

whyrusleeping opened this issue Aug 5, 2016 · 1 comment · Fixed by #3132
Assignees

Comments

@whyrusleeping
Copy link
Member

we need to change our multistream protocol id's to match what is expected by js-ipfs. In order to do that, we have proposed changing the multistream interface to expose the selected version on the stream object passed to the handler so that protocols will be able to detect which version they are communicating over and behave accordingly.

related:

@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Aug 5, 2016
@whyrusleeping whyrusleeping added this to the js-go interoperability milestone Aug 5, 2016
@whyrusleeping
Copy link
Member Author

There is also the problem of knowing which protocol to dial to for a new peer. Trying both at the same time is wasteful, trying one and then the other increases latency. I propose that we start using the protocols field of the identify handshake to seed the peerstore with info on what protocols are supported by each peer we connect to.

@whyrusleeping whyrusleeping self-assigned this Aug 26, 2016
@whyrusleeping whyrusleeping added status/in-progress In progress and removed help wanted Seeking public contribution on this issue labels Aug 26, 2016
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant