ipfs files stat buggy default format?

[jbenet]

Version/Platform/Processor information (from ipfs version --all):

0.4.3-rc3

Type (bug, feature, meta, test failure, question): bug
Area (api, commands, daemon, fuse, etc): commands / files
Priority (from P0: functioning, to P4: operations on fire): P1
Description:

SHOULD BE

> ipfs files stat /Makefile
Hash: QmTpkPUNCEqQwhNkR78zpc2WiwkQUxKi2G6yaB1THReX8y
Size: 4416
CumulativeSize: 4480
ChildBlocks: 1
Type: file

BUT IS

> ipfs files stat /Makefile
QmTpkPUNCEqQwhNkR78zpc2WiwkQUxKi2G6yaB1THReX8y
Size: 4416
CumulativeSize: 4480
ChildBlocks: 1
Type: file

See here: https://github.com/ipfs/go-ipfs/pull/2706/files#r76372532

[Kubuxu]

My comment on that thread:

It was so you could do ipfs files stat /file | head -1 to get the hash before format options were a thing. Changing it breaks CLI compatibility.

[jbenet]

Seems like it's been this way since 38fab91 -- Sep 2015.

Okay, this is relatively minor and only increases BP by a few points. To fix it though, i suggest:

• Add a format keyword (like hash and size) that shows it with Hash: <hash>. maybe --kv-format
• Add a keyword for current default version too (no Hash: prefix, maybe legacy?). maybe --legacy-format
• After that, we can change the default with a deprecation warning, and after some length of time passes.

Other:

• Glad the tests now use --hash