Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go-multiaddr-dns DefaultResolver instead of std lib Resolver #7260

Closed
cpacia opened this issue Apr 30, 2020 · 4 comments
Closed

Use go-multiaddr-dns DefaultResolver instead of std lib Resolver #7260

cpacia opened this issue Apr 30, 2020 · 4 comments
Labels
exp/beginner Can be confidently tackled by newcomers kind/enhancement A net-new feature or improvement to an existing feature need/maintainers-input Needs input from the current maintainer(s)

Comments

@cpacia
Copy link

cpacia commented Apr 30, 2020

Would be nice to swap out the net.LookupTXT in the dns resolver for the madns.DefaultResolver.LookupTXT function.

This would allow one to just override the madns.DefaultResolver and it would work for both libp2p and IPFS. As it stands now there is no way to configure this resolver.

https://github.com/ipfs/go-ipfs/blob/f006fc164771d6ab2e2b2608992bc6e5d1f17a8f/namesys/dns.go#L28
@cpacia cpacia added the kind/enhancement A net-new feature or improvement to an existing feature label Apr 30, 2020
@matyapiro31
Copy link

Ref: #6915

@hsanjuan hsanjuan added exp/beginner Can be confidently tackled by newcomers need/maintainers-input Needs input from the current maintainer(s) labels May 4, 2020
@hsanjuan
Copy link
Contributor

hsanjuan commented May 4, 2020

@Stebalien this looks like an ok proposal unless I'm missing something.

@cpacia cpacia mentioned this issue May 29, 2020
Closed
@Stebalien
Copy link
Member

madns.DefaultResolver isn't quite right as madns and dnslink are two separate specs. Ideally we'd construct resolvers with the right dns resolver, but threading that through is difficult. We might need a global go-dns package.

@BigLep BigLep closed this as completed Mar 29, 2021
@lidel
Copy link
Member

lidel commented Mar 29, 2021 •
edited
Loading

FYSA we are tracking configurable DNS servers (for all record types) in #6532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/beginner Can be confidently tackled by newcomers kind/enhancement A net-new feature or improvement to an existing feature need/maintainers-input Needs input from the current maintainer(s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@BigLep @lidel @Stebalien @hsanjuan @cpacia @matyapiro31