Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent] Deprecated flags are ignored totally #1192

Closed
gouthamve opened this issue Nov 16, 2018 · 1 comment
Closed

[agent] Deprecated flags are ignored totally #1192

gouthamve opened this issue Nov 16, 2018 · 1 comment
Labels

Comments

@gouthamve
Copy link
Contributor

When a deprecated flag, for example, --discovery.min-peers=50 is set and the corresponding replacement flag is not set, then we would need MinPeers to take the value of 50. But the actual value is set to 3.

https://github.com/jaegertracing/jaeger/blob/master/cmd/agent/app/reporter/tchannel/flags.go#L82-L83
would always overwrite this (i.e, with default values even if the new flags are not set):
https://github.com/jaegertracing/jaeger/blob/master/cmd/agent/app/reporter/tchannel/flags.go#L70-L77

I've noticed this while fixing the failing tests for my PR: #1034
The fix is in the last commit of that PR, but I can cherry pick that into another PR if you want.

@gouthamve
Copy link
Contributor Author

Closed in #1034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants