Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document HTTP endpoints in query and collector services #158

Closed
badiib opened this issue May 12, 2017 · 5 comments
Closed

Document HTTP endpoints in query and collector services #158

badiib opened this issue May 12, 2017 · 5 comments

Comments

@badiib
Copy link
Contributor

badiib commented May 12, 2017

We don't really define our API anywhere, and we should do so. This is probably a good issue to bring up the idea of using swagger for self-documentation.

@yurishkuro
Copy link
Member

  • update documentation in deployment.md

@pavolloffay
Copy link
Member

Do you have any preference for the framework? What is the most used/mature one in Go?

I found this https://github.com/go-swagger/go-swagger

@yurishkuro
Copy link
Member

When you say framework, it implies not just documenting but refactoring the endpoints to use that framework so that documentation and code are in sync. I'd agree swagger is the way to go. However, we first need to investigate how it will work with graphql, because we certainly need graphql to streamline interactions with UI. I don't know if graphql frameworks also help with auto documenting the API.

@pavolloffay
Copy link
Member

@yurishkuro yurishkuro added this to the Release 1.0 milestone Oct 8, 2017
@yurishkuro
Copy link
Member

Duplicate of #456

@yurishkuro yurishkuro marked this as a duplicate of #456 Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants