Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that all packages have tests #168

Closed
yurishkuro opened this issue May 18, 2017 · 0 comments
Closed

Verify that all packages have tests #168

yurishkuro opened this issue May 18, 2017 · 0 comments
Assignees
@yurishkuro

Comments

@yurishkuro
Copy link
Member

When a package has .go files but no test files, it is not counted towards the code coverage, giving misleading total. The proposal is to do something similar to yarpc/yarpc-go#1043:

  • we already use .nocover files to skip packages with this file from running coverage
  • we should add another validation script that will fail if a package has .go files, no .nocover file, and has no tests
@yurishkuro yurishkuro mentioned this issue Jan 6, 2018
Merged
@ghost ghost assigned yurishkuro Jan 6, 2018
@ghost ghost added the review label Jan 6, 2018
@ghost ghost removed the review label Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yurishkuro