Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ES tag keys directly in the OTEL config file #2301

Closed
pavolloffay opened this issue Jun 22, 2020 · 5 comments
Closed

Expose ES tag keys directly in the OTEL config file #2301

pavolloffay opened this issue Jun 22, 2020 · 5 comments

Comments

@pavolloffay
Copy link
Member

Created from #2295 (comment)

Add tag keys directly in the OTEL config file instead of a separate tag key file.

      --es.tags-as-fields.config-file string                  (experimental) Optional path to a file containing tag keys which will be stored as object fields. Each key should be on a separate line.

@joe-elliott
Copy link
Member

@pavolloffay I'd like to work on this feature.

This is marked area/otel, but I assume this would require changes in the elastic search options, opentelemetry translator and the traditional jaeger es spanstore.

@pavolloffay
Copy link
Member Author

The Config/Options objects will have to be adjusted. The translator and spanstore shouldn't require any changes since they should already get parsed keys.

@joe-elliott
Copy link
Member

Ok, that's what I was seeing. Just wanted to make sure this wasn't an otel change only for some reason.

@joe-elliott
Copy link
Member

joe-elliott commented Aug 29, 2020

@pavolloffay this was fixed in #2417 and can be closed. I mentioned the wrong # in the PR. Apologies for the mixup.

@pavolloffay
Copy link
Member Author

Done in #2417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants