Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should opensearch be a recognized backend type? #3247

Closed
yurishkuro opened this issue Sep 6, 2021 · 3 comments · Fixed by #3255
Closed

Should opensearch be a recognized backend type? #3247

yurishkuro opened this issue Sep 6, 2021 · 3 comments · Fixed by #3255

Comments

@yurishkuro
Copy link
Member

In #3198 we added ability to auto-detect OpenSearch storage. Would it make sense to add opensearch as a valid backend choice for SPAN_STORAGE_TYPE?

cc @pavolloffay @jkowall @albertteoh @Ashmita152

@pavolloffay
Copy link
Member

I don't see much value by adding opensearch as a valid storage option right now. It will make more sense once opensearch implementation diverges.

That said I don't have a strong opinion to add it right now and use the same implementation for both elasticsearch and opensearch.

@yurishkuro
Copy link
Member Author

yurishkuro commented Sep 9, 2021

Yes, I meant using the same implementation for now. Having explicit opensearch option would server to goals:

  • be a forward-compatible configuration option, since I am fairly certain we'll need to do it at some point in the future
  • a bit of a positional statement saying that we prefer to support liberally-licensed storage, not the new ES license

@yurishkuro
Copy link
Member Author

@pavolloffay #3255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants