Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming SPAN_STORAGE env var to SPAN_STORAGE_TYPE #642

Closed
yurishkuro opened this issue Jan 11, 2018 · 3 comments
Closed

Consider renaming SPAN_STORAGE env var to SPAN_STORAGE_TYPE #642

yurishkuro opened this issue Jan 11, 2018 · 3 comments
Assignees

Comments

@yurishkuro
Copy link
Member

I noticed this discussion about Jaeger Helm chart: helm/charts#3109 (comment)

The original --span-storage.type cli switch that was deprecated in #625 in favor of SPAN_STORAGE env var was actually previously mapped to SPAN_STORAGE_TYPE env var.

We could achieve better backwards compatibility by renaming

  • SPAN_STORAGE => SPAN_STORAGE_TYPE
  • DEPENDENCY_STORAGE => DEPENDENCY_STORAGE_TYPE (for consistency).

Worth it? It does take more characters to type.

cc @black-adder @objectiser @pavolloffay

@black-adder
Copy link
Contributor

makes sense, given the refactor was technically a breaking change, anything to make the transition easier is worth it.

@pavolloffay
Copy link
Member

+1 on this

@objectiser
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants