Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs update to ee11 dependencies like jakarta.el-api 6.0.0 #257

Open
janbartel opened this issue May 2, 2024 · 10 comments
Open

Needs update to ee11 dependencies like jakarta.el-api 6.0.0 #257

janbartel opened this issue May 2, 2024 · 10 comments

Comments

@janbartel
Copy link

No description provided.

@pnicolucci
Copy link
Contributor

Hi @janbartel changes to Jakarta Tags 3.0 were made here: #254 for Jakarta EE11. We're planning a service release soon.

@pnicolucci
Copy link
Contributor

@janbartel We've release a 3.0.1 version of the Jakarta Tags API. See the following for details and maven coordinates: https://jakarta.ee/specifications/tags/3.0/

Are you ok if we close this issue? I'll wait a week for a response and then close if there is nothing else. Thank you!

@arjantijms
Copy link
Contributor

@pnicolucci I'm afraid we need a 3.0.2 version still. We missed a single value for the update.

The MANIFEST.MF (printed using the bnd command for readability) now contains this:

Import-Package                          jakarta.el;version="[5.0,7)"
                                        jakarta.servlet.http;version="[6.0,7)"
                                        jakarta.servlet.jsp.jstl.core
                                        jakarta.servlet.jsp.tagext;version="[3.1,4)"
                                        jakarta.servlet.jsp;version="[3.1,5)"
                                        jakarta.servlet;version="[6.0,7)"
                                        javax.xml.parsers
                                        org.xml.sax
                                        org.xml.sax.helpers

jakarta.servlet.jsp.tagext was not updated and still required Pages/JSP 3.x. We all missed this :(

@pnicolucci
Copy link
Contributor

@arjantijms thanks for finding that, I can't believe I missed that in the original PR. I'll get a PR up for the change and can stage a 3.0.2 for testing.

@pnicolucci
Copy link
Contributor

@arjantijms #263 if you could review that would be great :)

@pnicolucci
Copy link
Contributor

@arjantijms Tags API 3.0.2 is staged! Can you take another look and verify we're all good this time around. It looked good to me. Thanks!

@arjantijms
Copy link
Contributor

I just build GlassFish with it, and it seems fine. Inspecting the binary build with bnd reveals:

Bnd-LastModified                        1724345517089
Build-Jdk-Spec                          11
Bundle-Description                      Jakarta Standard Tag Library 3.0 Specification
Bundle-DocURL                           https://www.eclipse.org
Bundle-License                          http://www.eclipse.org/legal/epl-2.0
                                        https://www.gnu.org/software/classpath/license.html
Bundle-ManifestVersion                  2
Bundle-Name                             Jakarta Standard Tag Library API
Bundle-SymbolicName                     jakarta.servlet.jsp.jstl-api
Bundle-Vendor                           Eclipse Foundation
Bundle-Version                          3.0.2
Created-By                              Apache Maven Bundle Plugin
Export-Package                          jakarta.servlet.jsp.jstl.core;uses:="jakarta.el,jakarta.servlet,jakarta.servlet.http,jakarta.servlet.jsp,jakarta.servlet.jsp.tagext";version="3.0.2"
                                        jakarta.servlet.jsp.jstl.fmt;uses:="jakarta.servlet.jsp";version="3.0.2"
                                        jakarta.servlet.jsp.jstl.sql;version="3.0.2"
                                        jakarta.servlet.jsp.jstl.tlv;uses:="jakarta.servlet.jsp.tagext";version="3.0.2"
Extension-Name                          jakarta.servlet.jsp.jstl
Implementation-Vendor                   Eclipse Foundation
Implementation-Vendor-Id                org.glassfish
Implementation-Version                  3.0.2
Import-Package                          jakarta.el;version="[5.0,7)"
                                        jakarta.servlet.http;version="[6.0,7)"
                                        jakarta.servlet.jsp.jstl.core
                                        jakarta.servlet.jsp.tagext;version="[3.1,5)"
                                        jakarta.servlet.jsp;version="[3.1,5)"
                                        jakarta.servlet;version="[6.0,7)"
                                        javax.xml.parsers
                                        org.xml.sax
                                        org.xml.sax.helpers
Manifest-Version                        1.0
Require-Capability                      osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=11))"
Specification-Vendor                    Eclipse Foundation
Specification-Version                   3.0
Tool                                    Bnd-5.1.1.202006162103

I'll do a PR with the updated Tags jar and the patch we had in place removed, so the CI can check it for the final ok.

@arjantijms
Copy link
Contributor

See: eclipse-ee4j/glassfish#25112

CI passes without patches with the 3.0.2 jar

@pnicolucci
Copy link
Contributor

@arjantijms I'll work to release 3.0.2 today / tomorrow.

@pnicolucci
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants