-
Notifications
You must be signed in to change notification settings - Fork 28
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Needs update to ee11 dependencies like jakarta.el-api 6.0.0 #257
Comments
Hi @janbartel changes to Jakarta Tags 3.0 were made here: #254 for Jakarta EE11. We're planning a service release soon. |
@janbartel We've release a 3.0.1 version of the Jakarta Tags API. See the following for details and maven coordinates: https://jakarta.ee/specifications/tags/3.0/ Are you ok if we close this issue? I'll wait a week for a response and then close if there is nothing else. Thank you! |
@pnicolucci I'm afraid we need a 3.0.2 version still. We missed a single value for the update. The MANIFEST.MF (printed using the bnd command for readability) now contains this:
|
@arjantijms thanks for finding that, I can't believe I missed that in the original PR. I'll get a PR up for the change and can stage a 3.0.2 for testing. |
@arjantijms #263 if you could review that would be great :) |
@arjantijms Tags API 3.0.2 is staged! Can you take another look and verify we're all good this time around. It looked good to me. Thanks! |
I just build GlassFish with it, and it seems fine. Inspecting the binary build with bnd reveals:
I'll do a PR with the updated Tags jar and the patch we had in place removed, so the CI can check it for the final ok. |
See: eclipse-ee4j/glassfish#25112 CI passes without patches with the 3.0.2 jar |
@arjantijms I'll work to release 3.0.2 today / tomorrow. |
No description provided.
The text was updated successfully, but these errors were encountered: