Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow using native window decorations/titlebar #3093

Open
1 task done
ethanc8 opened this issue Jun 23, 2024 · 1 comment
Open
1 task done

feat: Allow using native window decorations/titlebar #3093

ethanc8 opened this issue Jun 23, 2024 · 1 comment
Assignees
Labels

Comments

@ethanc8
Copy link

ethanc8 commented Jun 23, 2024

  • I have searched the existing issues

Is your feature request related to a problem? Please describe it

In versions before v0.5.x, Jan used the system's native window decorations (titlebar, window borders, shadow behind windows, etc). However, in v0.5.1, Jan draws its own titlebar and does not implement things like shadows behind the window or the platform-native right-click menu, at least on Linux with the KDE desktop environment. This makes Jan feel unnatural and annoying to use, as the lack of shadows behind the window cause the window to blend in to other windows, and it generally does not feel like a normal window.

Describe the solution

As a bare minimum, an option should be added to the appearance settings to allow the native window decorations to be used. If possible, we should replace Jan's custom titlebar with the Electron menubar (File, Edit, Help...) when native window decorations are being used. Another thing we could look into is improving the behavior of the nonnative window decorations, such as implementing drop shadows and right-click on the titlebar. This is something that all Electron apps suffer from, while Gtk apps don't suffer as much because the Gtk theme typically implements behavior close to native for Gtk apps that draw their own window decorations.

Teachability, documentation, adoption, migration strategy

On some platforms, the titlebar and window borders of the Jan main window may feel out of place or odd. If you are bothered by this, you can go to Settings > Appearance > Window Decorations, select "Native Window Decorations", and reopen the app.

What is the motivation / use case for changing the behavior?

This behavior is a regression from v0.4.x. It also makes the menubar harder to access.

@sndurkin
Copy link

+1, another useful feature of having native window decorations is that in Windows, you can use hotkeys to move the window between desktops and maximize it, and this seems to be lost in v0.5+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

3 participants