Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototypal inheritance with EventEmitter #8

Open
mvladic opened this issue Dec 10, 2015 · 0 comments
Open

Prototypal inheritance with EventEmitter #8

mvladic opened this issue Dec 10, 2015 · 0 comments

Comments

@mvladic
Copy link

mvladic commented Dec 10, 2015

I'm experiencing some bugs because _events from EventEmitter is shared between Client instances.

Check this out:

nodejs/node-v0.x-archive#7157

In client.js, instead of:

// inherit from EventEmitter
Client.prototype = new EventEmitter();

it should be:

// inherit from EventEmitter
util.inherits(Client, EventEmitter);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvladic