From 937ae102e7efc4ac9b561d818263b26b8296a125 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 12 Jun 2024 12:57:42 +0200 Subject: [PATCH] tools: do not run Corepack code before it's reviewed Also enable running `make corepack-update` when `node`/`npm` is not available globally. PR-URL: https://github.com/nodejs/node/pull/53405 Reviewed-By: Luigi Pinca Reviewed-By: James M Snell --- Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 9291c73e568dd1..c07ffb28c38169 100644 --- a/Makefile +++ b/Makefile @@ -1151,13 +1151,14 @@ pkg: $(PKG) .PHONY: corepack-update corepack-update: mkdir -p /tmp/node-corepack - curl -qLo /tmp/node-corepack/package.tgz "$$(npm view corepack dist.tarball)" + curl -qLo /tmp/node-corepack/package.tgz "$$($(call available-node,$(NPM) view corepack dist.tarball))" rm -rf deps/corepack && mkdir deps/corepack cd deps/corepack && tar xf /tmp/node-corepack/package.tgz --strip-components=1 chmod +x deps/corepack/shims/* - node deps/corepack/dist/corepack.js --version + $(call available-node,'-p' \ + 'require(`./deps/corepack/package.json`).version') .PHONY: pkg-upload # Note: this is strictly for release builds on release machines only.