Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some input validation to .make_ascii_maker #9

Open
jayqi opened this issue Feb 1, 2019 · 0 comments
Open

Add some input validation to .make_ascii_maker #9

jayqi opened this issue Feb 1, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@jayqi
Copy link
Owner

jayqi commented Feb 1, 2019

There are some assumptions by .make_ascii_maker around the inputs. To be safe, it would be great to have some input validation there. If we want to maintain 100% code coverage, we'd also have to write tests.

For now this is an internal function so it's not a huge priority. It's a pain to validate (and then test the validation) for 3 different conditions on these 5 inputs. Maybe a good code-golfing exercise.

@jayqi jayqi added the enhancement New feature or request label Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant