Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http Proxy? #3238

Open
2 tasks done
cosydney opened this issue May 4, 2023 · 3 comments
Open
2 tasks done

Http Proxy? #3238

cosydney opened this issue May 4, 2023 · 3 comments
Labels
awaiting upstream question

Comments

@cosydney
Copy link

cosydney commented May 4, 2023

Description
Can we pass a proxy to a Gitbeaker api client?

I've seen this issue #2014 and this PR: #2482 but it's not completely clear if it's feasible or not.

Thank you

Checklist

  • I have checked that this is not a duplicate issue.
  • I have read the documentation.
@jdalrymple
Copy link
Owner

Currently I'm unsure. With the switch to the native fetch lib for all the requests, im not sure how it handles proxying. I asked that question on the PR proposed but didnt receive a response.

@jdalrymple
Copy link
Owner

Did some digging, its a feature thats in the works! nodejs/node#43187

@jdalrymple
Copy link
Owner

The underlying logic does support it, but the node impl doesnt expose this. I think they mention a work around, though it seems a bit hacky haha. BUT! There are these changes that do look promising and might be released soon with a much nicer impl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting upstream question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdalrymple @cosydney