Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency constraint to allow for tzinfo v2.0.0 #7565

Closed
jekyllbot opened this issue Mar 10, 2019 · 5 comments
Closed

Update dependency constraint to allow for tzinfo v2.0.0 #7565

jekyllbot opened this issue Mar 10, 2019 · 5 comments

Comments

@jekyllbot
Copy link
Contributor

Hey there! 👋

I noticed that the constraint you have for tzinfo doesn't allow for the latest version to be used.

The constraint I found was ~> 1.2, and the latest version available is 2.0.0.

Can you look into updating that constraint so our users can use the latest and greatest version? Thanks! 💞

@changwh
Copy link

changwh commented Mar 17, 2019

Yes, I think the latest version of tzinfo will cause the problem like this:
Add timezone: Asia/Shanghai in _config.yml
Add date: 2019-03-17 16:55:00 +0800 in the head part of .md file
Run jekyll build --verbose and it outputs:

    Requiring: tzinfo
    Timezone: Asia/Shanghai 00:00

It's so weird...

And then change the version of tzinfo to1.2.0,everything works...
Actually I'm not sure if I'm right...lol

@ashmaroli
Copy link
Member

@changwh You're absolutely correct regarding the observations with tzinfo-2.0. The observation yo've made is a known issue and has been mentioned in Jekyll's documentation.

Jekyll won't migrate to tzinfo-2.0 as activesupport is still locked to the v1.x series.
Besides, the gain from migrating is lesser than handling the version conflicts.

@changwh
Copy link

changwh commented Mar 18, 2019

@changwh You're absolutely correct regarding the observations with tzinfo-2.0. The observation yo've made is a known issue and has been mentioned in Jekyll's documentation.

Jekyll won't migrate to tzinfo-2.0 as activesupport is still locked to the v1.x series.
Besides, the gain from migrating is lesser than handling the version conflicts.

Thank you for your reply and clarification. I just found it in Jekyll's documentation, but it's a little hard for us starters to match up the appearance with the real cause. lol

@ashmaroli
Copy link
Member

but it's a little hard for us starters to match up the appearance with the real cause.

Agreed. Running jekyll new with future releases (for v3.7.x and above) will generate the Gemfile with tzinfo locked to v1.x

@DirtyF
Copy link
Member

DirtyF commented May 9, 2020

@ashmaroli Should we close this then?

@ashmaroli ashmaroli removed the pinned label Jan 11, 2021
@DirtyF DirtyF added the breaking-change Affect current behavior label Jan 11, 2021
@jekyll jekyll locked and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants