Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should invokeCount not be invokeTotal? #65

Open
Jimmy89 opened this issue Feb 9, 2024 · 0 comments
Open

Should invokeCount not be invokeTotal? #65

Jimmy89 opened this issue Feb 9, 2024 · 0 comments

Comments

@Jimmy89
Copy link

Jimmy89 commented Feb 9, 2024

If you look at line 106 where is being checked whether a delay must be triggered within the lambda, the code looks at invokeCount, which increases for every invoke. I think this should be invokeCount >= invokeTotal, as otherwise only the first lambda that is called will be delayed, while all up following lambda triggers will have no delay (e.g. invokeTotal = 5, than invokeCount > 1 is true 4 times). In case invokeCount equals invokeTotal no delay is necessary.

Currently, this results into less lambda invokes that are warmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant