-
-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] ConnectionSelected event #103
Comments
Hello! Thanks a lot! 🎉 Good idea. If they could be added.
I will try to add it or if you want you can do a PR. Jero |
I pulled the project and tried to work on it but I couldn't make the dev environement work. Could you provide information to make it work for dev ? Like a ReadMe for contributing. I tried the dev script from the package.json |
Hi, Thank you for this quick update ! I tried the npm run dev script but it doesn't work. I removed the '--host 0.0.0.0' option in the dev script to serve the site on localhost and this works for me. Is there a reason for this '--host 0.0.0.0' option ? I think this complicate the dev environement and so contribution.s Once again, thank you for your reactivity ! |
Hi, The reason for the host 0.0.0.0, is that it allows to use localhost and the local IP (which allows to see it on the phone at the same time, since the library supports mobile) I see that it is a very common problem. I will add it to the contribution file. I close the issue, thank you! ;) |
Hello,
First I want to say thank you for this library. I've been using it for few weeks and it works well even if it is a small lib, nice job !
Is is possible to add a ConnectionSelected even similar to the NodeSelected event ? I quickly check the library and it seems that it could be easy to add as the event is already detected inside the lib but not dispatch.
In this event it would be nice to have the node the id_output, id_input, output_class, input_class values (the same as the connection creation).
What do you think about this? If you think this is a good idea I could work on a Pull Request
Have a nice day ! :)
The text was updated successfully, but these errors were encountered: