Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update htmlparser2 dependency to v4.0.0 #9

Open
Leftium opened this issue Feb 9, 2020 · 0 comments
Open

Update htmlparser2 dependency to v4.0.0 #9

Leftium opened this issue Feb 9, 2020 · 0 comments

Comments

@Leftium
Copy link

Leftium commented Feb 9, 2020

When birch-outline is included in a project with rollup, a circular dependency error occurs like this: fb55/htmlparser2#256

The fix required appears to be in v4 of htmlparser2.

Additionally, I can't get birch-outline to build:

$ ./node_modules/gulp/bin/gulp.js prepublish
[16:52:59] Requiring external module coffeescript/register
fs.js:27
const { Math, Object } = primordials;
                         ^

ReferenceError: primordials is not defined
    at fs.js:27:26
...
$ ./node_modules/gulp/bin/gulp.js
[16:54:48] Requiring external module coffeescript/register
fs.js:27
const { Math, Object } = primordials;
                         ^

ReferenceError: primordials is not defined
    at fs.js:27:26
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant