error: no viable conversion from 'std::atomic<int>' to 'const UniValue'

[luke-jr]

Regression introduced by PR #61

With GCC 9.3.0, building Bitcoin Core 0.17+:

rpc/blockchain.cpp:2077:35: error: no viable conversion from 'std::atomic<int>' to 'const UniValue'
        result.pushKV("progress", g_scan_progress);
                                  ^~~~~~~~~~~~~~~

[luke-jr]

@promag

[promag]

You think it should be reverted or that code should change to g_scan_progress.load()?

[luke-jr]

If the API is going to change, it should wait for 2.0 I guess

[luke-jr]

(It does seem cleaner to simply allow it implicitly, though)