Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make screenshots script needs to be functionalized and added into ottrpal #145

Open
cansavvy opened this issue Jul 1, 2024 · 0 comments
Assignees
Labels

Comments

@cansavvy
Copy link
Contributor

cansavvy commented Jul 1, 2024

What needs to be done:

make-screenshots.R needs to be functionalized and added to the ottrpal package (along with a unit test).

Currently its called like this:

Rscript --vanilla make_screenshots.R \
            --git_pat ${{ secrets.GH_PAT }} \
            --repo $GITHUB_REPOSITORY \
            --output_dir resources/chapt_screen_images

So each of these options should become arguments in the new function.

After an initial PR that adds this as a function (along with a test in both test-rmd-leanpub-prep.R and test-quarto-leanpub-prep.R

Then later:

  • This change in the ottrpal package would need to be updated in the base_ottr image
  • Then this job in the render_all.yml needs to be updated to use the base_ottr image and the new ottrpal function.
@kweav kweav self-assigned this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants