Encoding parameter for Document class (2 issues)

[0xSekar]

In this block,

selling-partner-api/lib/Document.php

Lines 126 to 137 in 8b5cdc6

	if (!is_null($encoding) && !in_array(strtoupper($encoding), mb_list_encodings())) {
	$encoding = null;
	} else {
	$encodings = ['UTF-8'];
	if ($response->hasHeader('content-type')) {
	$httpContentType = $response->getHeader('content-type');
	$parsedHeader = \GuzzleHttp\Psr7\Header::parse($httpContentType);
	if (isset($parsedHeader[0]['charset'])) {
	array_unshift($encodings, $parsedHeader[0]['charset']);
	}
	}
	$encoding = mb_detect_encoding($contents, $encodings, true);

if encoding is passed and is valid, the if at line 126 is false so the else is executed, overriding the encoding parameter with the encoding in the response header. I think that if the parameter is passed and valid, it must override the one from the response.

Second problem is the Content-type response from Amazon for some reports in Europe. Instead of ISO-8859-1, amazon is sending Cp1252 that is not in the list of supported php encodings, rendering the auto-detect feature useless for some EU reports.

[quazardous]

Is it related to #336 ?

[0xSekar]

Is it related to #336 ?

I Don't think it is directly related. Similar issues, but one is for downloads while the other is for upload

[jlevers]

fixed in v5.2.1.