From 3e62e4a23e6074f763492771960b179405d6739e Mon Sep 17 00:00:00 2001 From: Gerhard Olsson Date: Sat, 22 Aug 2020 18:40:42 +0200 Subject: [PATCH 1/5] Remove Froyo specific views Not needed when minimum target is 15 --- app/res/drawable/fab_compat_bg.xml | 5 -- app/res/layout-v15/feed_row_activity.xml | 9 --- app/res/layout-v15/history.xml | 64 ------------------- app/res/layout-v15/start_fab.xml | 11 ---- app/res/layout/feed_row_activity.xml | 21 +----- .../{layout-v14 => layout}/feed_widget.xml | 0 .../feed_widget_item.xml | 0 app/res/layout/history.xml | 41 ++++++------ app/res/layout/start_fab.xml | 5 +- app/res/values-v14/dimens.xml | 10 --- app/res/values/dimens.xml | 2 +- .../feed_widget_provider_info.xml | 0 12 files changed, 29 insertions(+), 139 deletions(-) delete mode 100644 app/res/drawable/fab_compat_bg.xml delete mode 100644 app/res/layout-v15/feed_row_activity.xml delete mode 100644 app/res/layout-v15/history.xml delete mode 100644 app/res/layout-v15/start_fab.xml rename app/res/{layout-v14 => layout}/feed_widget.xml (100%) rename app/res/{layout-v14 => layout}/feed_widget_item.xml (100%) delete mode 100644 app/res/values-v14/dimens.xml rename app/res/{xml-v14 => xml}/feed_widget_provider_info.xml (100%) diff --git a/app/res/drawable/fab_compat_bg.xml b/app/res/drawable/fab_compat_bg.xml deleted file mode 100644 index 62e5a932b..000000000 --- a/app/res/drawable/fab_compat_bg.xml +++ /dev/null @@ -1,5 +0,0 @@ - - - - - \ No newline at end of file diff --git a/app/res/layout-v15/feed_row_activity.xml b/app/res/layout-v15/feed_row_activity.xml deleted file mode 100644 index d55f6659a..000000000 --- a/app/res/layout-v15/feed_row_activity.xml +++ /dev/null @@ -1,9 +0,0 @@ - - - - - - \ No newline at end of file diff --git a/app/res/layout-v15/history.xml b/app/res/layout-v15/history.xml deleted file mode 100644 index ffe86a9e7..000000000 --- a/app/res/layout-v15/history.xml +++ /dev/null @@ -1,64 +0,0 @@ - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/app/res/layout-v15/start_fab.xml b/app/res/layout-v15/start_fab.xml deleted file mode 100644 index f33e71bf7..000000000 --- a/app/res/layout-v15/start_fab.xml +++ /dev/null @@ -1,11 +0,0 @@ - - \ No newline at end of file diff --git a/app/res/layout/feed_row_activity.xml b/app/res/layout/feed_row_activity.xml index d546c576c..d55f6659a 100644 --- a/app/res/layout/feed_row_activity.xml +++ b/app/res/layout/feed_row_activity.xml @@ -1,24 +1,9 @@ - - + - + \ No newline at end of file diff --git a/app/res/layout-v14/feed_widget.xml b/app/res/layout/feed_widget.xml similarity index 100% rename from app/res/layout-v14/feed_widget.xml rename to app/res/layout/feed_widget.xml diff --git a/app/res/layout-v14/feed_widget_item.xml b/app/res/layout/feed_widget_item.xml similarity index 100% rename from app/res/layout-v14/feed_widget_item.xml rename to app/res/layout/feed_widget_item.xml diff --git a/app/res/layout/history.xml b/app/res/layout/history.xml index 1238a5fd0..ffe86a9e7 100644 --- a/app/res/layout/history.xml +++ b/app/res/layout/history.xml @@ -1,20 +1,22 @@ + + ~ Copyright (C) 2012 jonas.oreland@gmail.com + ~ + ~ This program is free software: you can redistribute it and/or modify + ~ it under the terms of the GNU General Public License as published by + ~ the Free Software Foundation, either version 3 of the License, or + ~ (at your option) any later version. + ~ + ~ This program is distributed in the hope that it will be useful, + ~ but WITHOUT ANY WARRANTY; without even the implied warranty of + ~ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + ~ GNU General Public License for more details. + ~ + ~ You should have received a copy of the GNU General Public License + ~ along with this program. If not, see . + --> + - + tools:ignore="UnusedAttribute"/> \ No newline at end of file diff --git a/app/res/layout/start_fab.xml b/app/res/layout/start_fab.xml index 304a04b05..f33e71bf7 100644 --- a/app/res/layout/start_fab.xml +++ b/app/res/layout/start_fab.xml @@ -1,10 +1,11 @@ - \ No newline at end of file diff --git a/app/res/values-v14/dimens.xml b/app/res/values-v14/dimens.xml deleted file mode 100644 index 4db8c5906..000000000 --- a/app/res/values-v14/dimens.xml +++ /dev/null @@ -1,10 +0,0 @@ - - - - - 0dp - - \ No newline at end of file diff --git a/app/res/values/dimens.xml b/app/res/values/dimens.xml index ad4618a32..74fab015c 100644 --- a/app/res/values/dimens.xml +++ b/app/res/values/dimens.xml @@ -5,7 +5,7 @@ Refer to App Widget Documentation for margin information http://developer.android.com/guide/topics/appwidgets/index.html#CreatingLayout --> - 8dp + 0dp 88dp 16dp diff --git a/app/res/xml-v14/feed_widget_provider_info.xml b/app/res/xml/feed_widget_provider_info.xml similarity index 100% rename from app/res/xml-v14/feed_widget_provider_info.xml rename to app/res/xml/feed_widget_provider_info.xml From 37812a99e342c6f4efa6c6e46c737acfaeac1c9b Mon Sep 17 00:00:00 2001 From: Gerhard Olsson Date: Sat, 22 Aug 2020 19:25:41 +0200 Subject: [PATCH 2/5] Make view ids unique --- ANT-Android-SDKs | 2 +- app/res/layout/account.xml | 10 +++++----- app/res/layout/account_row.xml | 12 +++++------ app/res/layout/bottom_tab_indicator.xml | 2 +- app/res/layout/create_advanced_workout.xml | 4 ++-- app/res/layout/feed.xml | 2 +- app/res/layout/filepermission.xml | 4 ++-- app/res/layout/history.xml | 4 ++-- app/res/layout/history_row.xml | 2 +- app/res/layout/manage_workouts.xml | 4 ++-- app/res/layout/reportlist_row.xml | 6 +++--- app/res/layout/run.xml | 16 +++++++-------- app/res/layout/start.xml | 2 +- app/res/layout/start_advanced.xml | 2 +- app/res/layout/start_basic.xml | 2 +- app/res/layout/start_interval.xml | 4 ++-- app/res/layout/step_dialog.xml | 16 +++++++-------- app/res/layout/upload.xml | 20 +++++++++---------- app/res/layout/userpass.xml | 6 +++--- app/res/layout/workout_row.xml | 8 ++++---- .../main/org/runnerup/export/SyncManager.java | 4 ++-- .../org/runnerup/view/AccountActivity.java | 4 ++-- .../runnerup/view/AccountListActivity.java | 12 +++++------ .../org/runnerup/view/DetailActivity.java | 6 +++--- .../org/runnerup/view/HistoryActivity.java | 2 +- .../main/org/runnerup/view/RunActivity.java | 16 +++++++-------- .../main/org/runnerup/view/StartActivity.java | 8 ++++---- .../main/org/runnerup/view/StepButton.java | 17 ++++++++-------- .../org/runnerup/view/UploadActivity.java | 2 +- wear/src/main/res/layout/searching.xml | 2 +- wear/src/main/res/layout/stopped.xml | 4 ++-- 31 files changed, 102 insertions(+), 103 deletions(-) diff --git a/ANT-Android-SDKs b/ANT-Android-SDKs index 0c79ecfb7..0e31a1bbb 160000 --- a/ANT-Android-SDKs +++ b/ANT-Android-SDKs @@ -1 +1 @@ -Subproject commit 0c79ecfb7d582ae75f243d345296fcd1b068a5a1 +Subproject commit 0e31a1bbb9a219d6e332e22f65570b38a39d71ea diff --git a/app/res/layout/account.xml b/app/res/layout/account.xml index 2a1b6dd3e..fde83843b 100644 --- a/app/res/layout/account.xml +++ b/app/res/layout/account.xml @@ -24,14 +24,14 @@ + android:layout_below="@id/account_view" > diff --git a/app/res/layout/account_row.xml b/app/res/layout/account_row.xml index b4fee2241..a2ffa5bfb 100644 --- a/app/res/layout/account_row.xml +++ b/app/res/layout/account_row.xml @@ -24,7 +24,7 @@ android:padding="16dp"> - + android:layout_above="@+id/manage_button_table" /> diff --git a/app/res/layout/reportlist_row.xml b/app/res/layout/reportlist_row.xml index 49de997ff..8841ff597 100644 --- a/app/res/layout/reportlist_row.xml +++ b/app/res/layout/reportlist_row.xml @@ -21,14 +21,14 @@ android:orientation="horizontal" > + android:layout_above="@+id/run_table_row2" >