Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of timeout settings #41

Closed
joshgoebel opened this issue Jun 16, 2022 · 5 comments
Closed

Name of timeout settings #41

joshgoebel opened this issue Jun 16, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request help welcome Help/contrib is esp welcome question Further information is requested

Comments

@joshgoebel
Copy link
Owner

@RedBearAK thoughts?

I'm thinking:

  • multipurpose
  • suspend
  • exert_post_combo

And yes we would document these and their uses...

timeouts(
  multipurpose = 1,
  suspend = 0.1,
  exert_post_combo: 0.25
)

The old define_timeout API would set the multipurpose timeout, as it always has. The exert_post_combo I don't have yet but if I add it later it would prevent false keypresses AFTER a combo by adding a small delay there (to give the user a chance to lift the keys) before the keys were reexerted on the output (currently they are reexerted immediately). That seems far less risky to me than the suspend which is the delay that happens a mod is first held - and what breaks your Cmd-clicking.

@joshgoebel joshgoebel added enhancement New feature or request help welcome Help/contrib is esp welcome question Further information is requested labels Jun 16, 2022
@RedBearAK
Copy link
Contributor

exert_post_combo

This sounds like an interesting variation. But I'd need concrete examples of the flow with each of these to really have an opinion on anything.

give the user a chance to lift the keys

My mind strays to Option key shortcuts (physical Win/Super, logical Alt). This would help keep those shortcuts from opening menus, if you release within the timeout period?

@joshgoebel
Copy link
Owner Author

This would help keep those shortcuts from opening menus, if you release within the timeout period?

Yes, that's what suspend does (for initial keydowns) - though I suppose they could also incorrectly retrigger AFTER combos as well without exert_post_combo... I'm not sure why that isn't reported more as I'd think the problem would be the same.

But I'd need concrete examples

Pretty sure there are more examples in other threads. It's all about suspending the keys to try and predict the future.

  • suspend is just my name for holding back the initial key down
  • and exert_post_combo is my name for holding back pushing the keys down again after a combo

@RedBearAK
Copy link
Contributor

I kind of like the more verbose naming you were using in this thread, and the lack of exert:

#9 (comment)

@joshgoebel
Copy link
Owner Author

joshgoebel commented Jun 17, 2022

This is implemented in main now:

timeouts(
    multipurpose = 1,
    suspend = 1,
)

@joshgoebel joshgoebel self-assigned this Jun 17, 2022
@RedBearAK
Copy link
Contributor

@joshgoebel

This seems like an issue that could be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help welcome Help/contrib is esp welcome question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants