Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BackgroundCells.jsx selectable PropTypes should include 'ignoreEvents' string #244

Closed
IanLondon opened this issue Dec 28, 2016 · 1 comment
Closed

BackgroundCells.jsx selectable PropTypes should include 'ignoreEvents' string #244

IanLondon opened this issue Dec 28, 2016 · 1 comment

Comments

@IanLondon
Copy link
Contributor

it seems the selectable prop of BackgroundCells ought to be selectable: React.PropTypes.oneOf([true, false, 'ignoreEvents']), just like DayColumn.

BackgroundCells uses this logic on line 102: if (this.props.selectable !== 'ignoreEvents') return

Right now, it's selectable: React.PropTypes.bool only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jquense @IanLondon