Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When defining onSelecting, the same slot can't be dragged over using a mouse or long pressed using touch events multiple times in a row. #858

Closed
brenthosie opened this issue Jun 4, 2018 · 5 comments

Comments

@brenthosie
Copy link

Do you want to request a feature or report a bug?

report a bug

What's the current behavior?

When I use the onSelecting, selectable, and onSelectSlot props together with each other, I can't do a drag selection of just 1 slot or a long press of 1 slot on a touch device multiple times back-to-back and have the onSelectSlot callback fire.

big-calendar-selection-bug

https://codesandbox.io/s/719rxl98m6

Browser: Chrome 66.0.3359.181

react-big-calendar @v0.19.1

What's the expected behavior?

When I use the onSelecting, selectable, and onSelectSlot props together with each other, I should be able to do a drag selection of just 1 slot or a long press of 1 slot on a touch device multiple times back-to-back and have the onSelectSlot callback fire.

@arecvlohe
Copy link
Collaborator

@brenthosie Are you saying you want to be to able to select and drag going from left to right instead of just top to bottom?

@brenthosie
Copy link
Author

brenthosie commented Aug 1, 2018

@arecvlohe no, the problem is that once you start a drag and only select 1 slot, then the callback of onSelectSlot stops firing reliably. What this also means is that since only drag is supported on touch devices (as a long press), then you can't select a slot reliably back-to-back.

In my gif i was dragging "left to right" so that you could see I was only doing a drag on one slot.

@arecvlohe
Copy link
Collaborator

Ah I see. @jquense will probably have more insight into this than I do.

@arecvlohe arecvlohe added the bug label Aug 1, 2018
@brenthosie
Copy link
Author

@arecvlohe any word on this?

@stale
Copy link

stale bot commented May 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants