instrumentation-remix: cloning incoming requests can lead to excessive memory usage

[abustany]

As we can see in

opentelemetry-instrumentations-js/packages/instrumentation-remix/src/instrumentation.ts

Line 405 in 36ee3ed

const clonedRequest = params.request.clone();

, incoming "action" requests are cloned so that some form attributes can be forwarded to span attributes. The cloning means that the entire request body gets buffered in memory, which can be problematic for example when uploading large files.

It feels that the code could clone the request only if those two conditions are met:

• the content type is a form content type (so formData() returns something)
• actionFormDataAttributes is set on the plugin config

the first point probably wouldn't help for directly large uploads (since multipart/form-data can still be decoded into a FormData), but the second would allow avoiding excessive memory usage where not needed?