Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't crash nix-build on spago build errors #25

Open
chekoopa opened this issue Feb 21, 2020 · 1 comment
Open

Doesn't crash nix-build on spago build errors #25

chekoopa opened this issue Feb 21, 2020 · 1 comment

Comments

@chekoopa
Copy link
Contributor

Got some errors on missing main module from Parcel, and only few retries later my eye caught few compie errors. After quick research I've realized that buildSpagoStyle script always exits with zero code, which would be inconvenient and error-prone.

I propose replacing:

purs compile ...
echo done.

with something like

purs compile ... && echo done.

So it would notify at successful builds only and keep build flow consistent.

@chekoopa chekoopa changed the title doesn't crash nix-build on spago build errors Doesn't crash nix-build on spago build errors Feb 21, 2020
@justinwoo
Copy link
Owner

the related code is here: https://github.com/justinwoo/spago2nix/blob/master/src/Generate.purs#L148-L168

do you want to make a PR for setting -e flags for the scripts? we can also remove them altogether to be honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants