Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Ability to Specify Namespace of Scheduler Estimator Services for Karmada Scheduler #5448

Closed
jabellard opened this issue Aug 28, 2024 · 8 comments · Fixed by #5478
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@jabellard
Copy link
Contributor

What would you like to be added:
When the scheduler estimator feature is enabled for the Karmada scheduler component, we can then provision scheduler estimator instances for member clusters that will provide the scheduler with more accurate information regarding resources for those member clusters.

To gain that information, given some member cluster, the scheduler needs to contact the service for that member cluster's scheduler estimator deployment. As of today, it uses a naming convention for discovering those services. By default, given some member cluster m1, it will look for a service named karmada-scheduler-estimator-m1 in the karmada-system namespace.
The service name prefix is configurable, but the namespace is not. This feature request is for providing the ability to configure the namespace in which the scheduler should try to discover the service.

Why is this needed:
At Bloomberg, we're currently building a managed Karmada platform and want to use the Karmada operator to manage the entire lifecycle of managed Karmada instances. Each tenant's control plane will live in a namespace in our host/management cluster. As such, we would also like to keep scheduler estimator instances scoped to their respective tenancy's namespace to avoid polluting the karmada-system namespace with instances across all managed tenancies.

@jabellard jabellard added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 28, 2024
@RainbowMango
Copy link
Member

The service name prefix is configurable, but the namespace is not. This feature request is for providing the ability to configure the namespace in which the scheduler should try to discover the service.

Yeah, I think it's a reasonable use case. What do you think? @whitewindmills @Garrybest

@whitewindmills
Copy link
Member

+1

@whitewindmills
Copy link
Member

/assign

@Garrybest
Copy link
Member

Nice catch. I think it's useful.

@RainbowMango
Copy link
Member

@whitewindmills We talked about this issue at the community meeting yesterday. One question from Joe (@jabellard) is do you want to take this task as he sees the assignment you made on this?

@RainbowMango RainbowMango added this to the v1.12 milestone Sep 4, 2024
@jabellard
Copy link
Contributor Author

@whitewindmills , I already looked into how to implement this change and have a PR I want to push.

@whitewindmills
Copy link
Member

okay, you can continue it.
/unassign
/assign @jabellard

@jabellard
Copy link
Contributor Author

@RainbowMango , just pushed a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Planned In Release 1.12
4 participants