Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MIN field from kubectl get scaledjob. #1552

Closed
Shubham82 opened this issue Feb 1, 2021 · 5 comments · Fixed by #1553
Closed

Remove MIN field from kubectl get scaledjob. #1552

Shubham82 opened this issue Feb 1, 2021 · 5 comments · Fixed by #1553
Labels
bug Something isn't working

Comments

@Shubham82
Copy link
Contributor

Shubham82 commented Feb 1, 2021

In latest release of KEDA(2.1.0), we added the functionality to show minimum and maximum replicacount for scaledobject and scaledjob when we run kubectl get scaledobject and kubectl get scaledjob but There is no minRelicaCount kind of thing for scaledjob or not define such thing when we creating scaledjob object, only maxRelicacount is there for scaledjob, see the scaledjob spec here. and scaledjob_types.go code here. so when we run kubectl get scaledjob it would show blank for MIN field

Expected Behavior

 Should not show MIN field when we  run `kubectl get scaledjob`

Actual Behavior

 Always show MIN field blank(nothing) when we run `kubectl get scaledjob`

Specifications

  • KEDA Version: 2.1.0
@Shubham82 Shubham82 added the bug Something isn't working label Feb 1, 2021
@Shubham82
Copy link
Contributor Author

Shubham82 commented Feb 1, 2021

@tomkerkhove @zroubalik Could you let me know if it is ok to remove the MIN field from kubectl get scaledjob. If this is valid i would like to work on this.

Thanks

@zroubalik
Copy link
Member

@Shubham82 good catch. Yes, would be great to fix this!

@Shubham82
Copy link
Contributor Author

Shubham82 commented Feb 1, 2021

Sure thanks @zroubalik ! I Will soon create a PR for it.

@Shubham82
Copy link
Contributor Author

@zroubalik i have Created a PR for it in #1553

@Shubham82
Copy link
Contributor Author

Hi @tomkerkhove @zroubalik should we also update our Helm chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants