Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated code for exposing Prometheus Metrics from Metrics Server #3930

Closed
zroubalik opened this issue Nov 29, 2022 · 2 comments · Fixed by #4479
Closed

Remove deprecated code for exposing Prometheus Metrics from Metrics Server #3930

zroubalik opened this issue Nov 29, 2022 · 2 comments · Fixed by #4479
Labels
feature-request All issues for new features that have not been committed to stale-bot-ignore All issues that should not be automatically closed by our stale bot

Comments

@zroubalik
Copy link
Member

Proposal

Search for [DEPRECATED] in metrics.proto, provider.go, scaler_handler.go, prometheus_metrics_test.go.

All the relevant code for pushing data for Prometheus Metrics from Operator to Metrics Server. We should expose metrics only from Operator.

Use-Case

No response

Anything else?

No response
@zroubalik zroubalik added needs-discussion feature-request All issues for new features that have not been committed to stale-bot-ignore All issues that should not be automatically closed by our stale bot and removed needs-discussion labels Nov 29, 2022
This was referenced Nov 29, 2022
Closed
Closed
Merged
@tomkerkhove tomkerkhove mentioned this issue Dec 7, 2022
Closed
@JorTurFer
Copy link
Member

This should be removed in v2.11

@JorTurFer
Copy link
Member

#4471
kedacore/charts#432
kedacore/keda-docs#1117

This was referenced Apr 25, 2023
Closed
Merged
Merged
@zroubalik zroubalik mentioned this issue Apr 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to stale-bot-ignore All issues that should not be automatically closed by our stale bot
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
2 participants
@zroubalik @JorTurFer