Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress nil value error in application insight scaler #4316

Closed
kia69028 opened this issue Mar 2, 2023 · 4 comments
Closed

Suppress nil value error in application insight scaler #4316

kia69028 opened this issue Mar 2, 2023 · 4 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@kia69028
Copy link

kia69028 commented Mar 2, 2023

Proposal

Hi team,

I would like to have the option to suppress the error of reading nil value as reading 0 in using application insights.

Use-Case

My use case is as follows:

I have a metric which only logs when there are incoming requests to the service. During the period of no requests, there will be no metrics. This caused the issue that over a time span with no activity, I am reading nil value over that metric, and this will put the scaled object into fallback (which I do not want) and flood the keda operator logs with error logs.

It would be great if there is an option to ignore the nil value error.

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

@kia69028 kia69028 added feature-request All issues for new features that have not been committed to needs-discussion labels Mar 2, 2023
@JorTurFer
Copy link
Member

Hi @kia69028
In prometheus Scaler, we have an option to treat nil as zero (returning 0 when nil is returned). Could this be enough for your use case?

image

@kia69028
Copy link
Author

kia69028 commented Mar 3, 2023

Hi @JorTurFer

Thank you for your replay. I saw that option in prometheus Scaler, and yes this is exactly what I want.
However, the issue is that I am using azure application insight scaler, which does not support this feature at the moment.
Therefore, I would want to know if there is any work around possible in azure application insight scaler.

Thank you!

@zroubalik
Copy link
Member

Hi @JorTurFer

Thank you for your replay. I saw that option in prometheus Scaler, and yes this is exactly what I want. However, the issue is that I am using azure application insight scaler, which does not support this feature at the moment. Therefore, I would want to know if there is any work around possible in azure application insight scaler.

Thank you!

IMHO it is not, but we are open to contributions. It's quite easy task, you can take inspiration from the Prom scaler.

@yardenshoham
Copy link
Contributor

Fixed by #4329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Archived in project
Development

No branches or pull requests

4 participants