Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide capability to get configuration from outside of scaledjob/scaledobject to configure triggers #5233

Closed
tomkerkhove opened this issue Dec 1, 2023 · 5 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity

Comments

@tomkerkhove
Copy link
Member

Proposal

Provide capability to get configuration from outside of scaledjob to configure triggers in a consistent manner across scalers.

Open requests:

Use-Case

No response

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

@zroubalik
Copy link
Member

zroubalik commented Dec 7, 2023

Just my thoughts on this:

  1. Introduce a TriggerMetadata CRD that can be referenced in ScaledObject the same way TriggerAuth, so trigger config can be shared across mutliple SOs/SJs. Though I am not sure if is any beneficial after all 😄 Is this really a use case? I think that usually you would like to modify the trigger settings per SO/SJ or scaleTarge
  2. Global configuration, where defaults can be set on a cluster/namespace level. A ConfigMap? Probably done via webhooks, if a value is not set in the trigger, then it will be added from the global config. To be able to implement this in a reasonable way, we would imho need to refactor trigger config handling.

@tomkerkhove tomkerkhove changed the title Provide capability to get configuration from outside of scaledjob to configure triggers Provide capability to get configuration from outside of scaledjob/scaledobject to configure triggers Jan 9, 2024
@tomkerkhove
Copy link
Member Author

^ @arapulido here is what you are looking for, but we probably need a design and samples of what it would look like

Copy link

stale bot commented Mar 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Mar 10, 2024
Copy link

stale bot commented Mar 21, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Mar 21, 2024
@panditha
Copy link

I am also looking for a global settings (may be a configmap) where we can customise the default values. For example I am looking for setting default polling interval to a value (other than 30 seconds) globally which will be applied on each scalars that don't explicitly define a polling interval. I think this is very common pattern/practice in Kubernetes to have global configmap to customise default settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity
Projects
Archived in project
Development

No branches or pull requests

3 participants