Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accent color change crashes KeePassXC with macOS Sonoma #10347

Closed
varjolintu opened this issue Mar 3, 2024 · 2 comments · Fixed by #10348
Closed

Accent color change crashes KeePassXC with macOS Sonoma #10347

varjolintu opened this issue Mar 3, 2024 · 2 comments · Fixed by #10348

Comments

@varjolintu
Copy link
Member

Overview

Changing Accent color in macOS crashes KeePassXC.

Steps to Reproduce

  1. Start KeePassXC
  2. Go to macOS System Preferences and change Accent color
  3. KeePassXC crashes

Context

Can be reproduced during debugging. Console has the following error:

KeePassXC[5831:127741] [General] An uncaught exception was raised
KeePassXC[5831:127741] [General] -[AppKitImpl interfaceThemeChanged:]: unrecognized selector sent to instance 0x10a583560

KeePassXC - From 2.7.6 to 2.8.0-snapshot
Build Type: Snapshot
Revision: dff2f18

Operating System: macOS Sonoma 14.3.1

@varjolintu
Copy link
Member Author

Everything works just fine after removing this: https://github.com/keepassxreboot/keepassxc/blob/develop/src/gui/osutils/macutils/AppKitImpl.mm#L45
Is it really needed? The event is still catched inside observeValueForKeyPath().

@varjolintu
Copy link
Member Author

A similar fix was made earlier: #8615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant