Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum commission per trade #113

Open
tankorsmash opened this issue Jul 19, 2020 · 5 comments · May be fixed by #839
Open

Minimum commission per trade #113

tankorsmash opened this issue Jul 19, 2020 · 5 comments · May be fixed by #839
Labels
enhancement New feature or request

Comments

@tankorsmash
Copy link
Contributor

Say I've got a 1.00$ minimum commission + 1% per trade, it doesn't appear to be possible to account for that, beyond just using a the commission=0.01 and ignoring the 1 dollar minimum.

Is such a thing possible?

Additional info

  • Backtesting version: 0.2.0
@tankorsmash tankorsmash changed the title Is it possible to set a minimum commission? Is it possible to set a minimum commission per trade? Jul 19, 2020
@kernc
Copy link
Owner

kernc commented Jul 19, 2020

Not possible. This would require an extra parameter, and we have nearly too many of those already, so I'm somewhat disinclined, more leaning to rule-of-thumb/ballpark estimations in that case.

Besides ignoring, I guess you can do accounting for (i.e. slightly increase commission rate for all trades, e.g. commission=.0125).

Do you make many trades where commissions sum to less than the minimum? In that case the relative commission model is completely flawed. But so might be your strategy ... 🤔

@kernc kernc changed the title Is it possible to set a minimum commission per trade? Minimum commission per trade Jul 19, 2020
@kernc kernc added the enhancement New feature or request label Jul 19, 2020
@casper-hansen
Copy link

Not possible. This would require an extra parameter, and we have nearly too many of those already, so I'm somewhat disinclined, more leaning to rule-of-thumb/ballpark estimations in that case.

Besides ignoring, I guess you can do accounting for (i.e. slightly increase commission rate for all trades, e.g. commission=.0125).

Do you make many trades where commissions sum to less than the minimum? In that case the relative commission model is completely flawed. But so might be your strategy ... 🤔

This issue is important for the whole repository. Most exchanges for stocks and futures charge a dollar commission, not a percentage like cryptocurrency. I think it's worth potentially adding a minimum commission nominated dollars/euros/etc.

Also, consider that this adds flexibility and enables more accurate backtesting.
image

@makovez
Copy link

makovez commented Jan 21, 2023

I have trouble to understand this phrase

Note, if you wish to account for bid-ask spread, you can approximate doing so by increasing the commission, e.g. set it to 0.0002 for commission-less forex trading where the average spread is roughly 0.2‰ of asking price.

if you set to 0.0002 then it would be 0.02 not 0.2%

0.2% would be 0.002 am i wrong?

@kernc
Copy link
Owner

kernc commented Jan 21, 2023

@makovez Notice the symbol in "0.2 " is per mille, not per cent. 😉

@makovez
Copy link

makovez commented Jan 21, 2023

Ops sorry. Never seen that symbol before. Now makes sense. Thanks.

so usually commission is around 0.02% of buy price?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants