Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance default analysis mode to be aware of application configurations #1837

Open
sjd78 opened this issue Apr 11, 2024 · 1 comment
Open
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sjd78
Copy link
Member

sjd78 commented Apr 11, 2024

Summary

When starting the analysis wizard, and selecting the analysis mode, a better default choice could be automatically made. This can avoid the case where there is a validation message displayed by static default choice. For example, we would like to avoid the analysis wizard opening looking like this:

Screenshot 2024-04-10 at 9 34 17 AM

Change requested

If 1 application has been selected to be analyzed and the application is configured to have...

  • Binary definitions only → select Binary
  • Source definitions only → select Source + Dependencies
  • Source and Binary definitions → select Source + Dependencies
  • No definitions → No default selection

If >1 application has been selected to be analyzed, two options are available:

  • Default to a static Source + Dependencies
  • Follow the same rules as for a single application and if they all select the same option, select that one. If any are different, default to a static Source + Dependencies

Reference

The enhancement follows up on #1364 and #1819 (comment)

@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Apr 11, 2024
@sjd78 sjd78 changed the title ✨ Enhance default analysis mode to be aware of application configurations Enhance default analysis mode to be aware of application configurations Jun 4, 2024
@sjd78 sjd78 added kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/minor Lowest priority. Possibly useful, but not yet enough support to actually get it done. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant