Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of @migtools/lib-ui #2044

Open
sjd78 opened this issue Aug 2, 2024 · 1 comment
Open

Remove the use of @migtools/lib-ui #2044

sjd78 opened this issue Aug 2, 2024 · 1 comment
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@sjd78
Copy link
Member

sjd78 commented Aug 2, 2024

There are a few places where types and functions from @migtools/lib-ui are used in the code. Since we're not maintaining the package anymore, we should drop it.

Additionally, dependencies from @migtools/lib-ui may cause issues. For example:

[sdickers@twilight tackle2-ui]$ npm why axios
axios@0.21.4 peer
node_modules/axios
  peer axios@"^0.21.2" from @migtools/lib-ui@10.0.1
  node_modules/@migtools/lib-ui
    @migtools/lib-ui@"^10.0.1" from @konveyor-ui/client@0.1.0
    client
      @konveyor-ui/client@0.1.0
      node_modules/@konveyor-ui/client
        workspace client from the root project

axios@1.6.8
client/node_modules/axios
  axios@"^1.6.8" from @konveyor-ui/client@0.1.0
  client
    @konveyor-ui/client@0.1.0
    node_modules/@konveyor-ui/client
      workspace client from the root project

We want axios@1.6.8 but axios@0.21.4 is still pulled in. Which npm is dealing with this situation ok, eventually the differences could start to cause problems.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 2, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Aug 2, 2024
@sjd78 sjd78 added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Aug 2, 2024
@sjd78 sjd78 self-assigned this Aug 2, 2024
@sjd78 sjd78 added this to the v0.6.0 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant