Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message after import should be passive #548

Closed
koppor opened this issue Dec 23, 2021 · 5 comments · Fixed by JabRef/jabref#9308 · May be fixed by Racheal7/jabref#3
Closed

Message after import should be passive #548

koppor opened this issue Dec 23, 2021 · 5 comments · Fixed by JabRef/jabref#9308 · May be fixed by Racheal7/jabref#3
Assignees

Comments

@koppor
Copy link
Owner

koppor commented Dec 23, 2021

grafik

The message should contain "created new entry" or "merged into existing entry"

@Racheal7
Copy link

Hi Oliver, can I take this issue? I am a student at the Australian National University and would like to contribute to the JabRef repo as part of my assignment.

Thank you~

@Racheal7
Copy link

@ThiloteE Hi there, thank you for assigning me.

Just want to clarify, my solution for the issue can be found in the Pull Requeset. However, as my team member pointed out, the messages are more like "past tense" rather than "passive". Is that okay or should I change the messages to passive tense such as "A new file was imported"?

In addition, the icon after successfully importing a BibTex is currently the "warning" icon, which I assume is a bug and it should be the "check" icon. I have already modified it in my PR but just want to confirm with you.

Thank you very much!

@ThiloteE
Copy link
Collaborator

Both Oliver Kopp and me are not native Speakers of the English language. Now that I think about it, yes a "passive" form of the past might be preferable. To be honest, since you study in Australia, which is an English Speaking Country, I think you might have a better feeling for what is right or wrong here. Whatever you choose, it will definitely be an improvement to the status quo.

@koppor
Copy link
Owner Author

koppor commented Oct 28, 2022

Everything was settled down at JabRef#9308 - no discussion needed any more.

@Racheal7 Thank you for working on this!

@Racheal7
Copy link

Thank you, Oliver @koppor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment