Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppleFmt Version error #529

Closed
baiyidjp opened this issue Jul 8, 2024 · 1 comment · Fixed by #551
Closed

AppleFmt Version error #529

baiyidjp opened this issue Jul 8, 2024 · 1 comment · Fixed by #551
Labels

Comments

@baiyidjp
Copy link

baiyidjp commented Jul 8, 2024

https://github.com/kstenerud/KSCrash/blob/8137c4990363b0ac7db5c11a48407c8713b6e1ff/Sources/KSCrashFilters/KSCrashReportFilterAppleFmt.m#L444C1-L445C78

shortVersion and bundleVersion are written inversely, Apple format should be 1.0.0 (10001), but is 10001 (1.0.0)

@GLinnik21 GLinnik21 added the bug label Jul 8, 2024
@GLinnik21
Copy link
Collaborator

GLinnik21 commented Jul 8, 2024

Hi!
The issue you've pointed out is due to Apple changing its format. This change was introduced to conform to Apple's format in #277. I can see that they now use the ver.si.on (build) format, although they haven't updated their documentation yet. Despite this, I think it's worth fixing.

As we're getting ready for version 2.0, if you have the time, we'd greatly appreciate if you could contribute a fix for this

@GLinnik21 GLinnik21 linked a pull request Aug 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants