Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up metadata, typemeta + listmeta + apistatus + apierror #36

Closed
clux opened this issue Jun 2, 2019 · 2 comments
Closed

clean up metadata, typemeta + listmeta + apistatus + apierror #36

clux opened this issue Jun 2, 2019 · 2 comments
Milestone
0.10.0

Comments

@clux
Copy link
Member

clux commented Jun 2, 2019 •
edited
Loading

Should have those structs fully in the library, and should probably flatten typemeta into Object.
ObjectList should get a ListMeta rather than ObjectMeta (rename), ApiStatus (rename to Status), should have ListMeta (ref) - probably also join ApiStatus and ApiError (same underlying object)

Ultimately small cleanups, but helps keep things consistent.
@clux clux changed the title clean up metadata, typemeta + listmeta clean up metadata, typemeta + listmeta + apistatus + apierror Jun 2, 2019
@clux clux added this to the 0.10.0 milestone Jun 2, 2019
@clux
Copy link
Member Author

clux commented Jun 2, 2019

Might not do the flattening and just have the explicit fields.. It's a bit annoying to have to type:

  • o.typemeta.kind rather than o.kind
  • o.typemeta.version rather than o.version

@clux
Copy link
Member Author

clux commented Jun 2, 2019

Added listmeta and renamed status in c14ef96

Now whether or not to re-export ApiError as Status 🤔

@clux clux closed this as completed in efbdf77 Jun 3, 2019
@clux clux mentioned this issue Jun 3, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
1 participant
@clux